[client] Minor client bugfixes #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State previously, on 0.12.5:
```
<#isso-thread>
<h2>
<.postbox>
<#isso-root>
```
Then, because configs needed to be fetched before rendering
the postbox because of:
02f3ea0 "Have client read out shared settings from server"
This was the state in 0.12.6:
```
<#isso-thread>
<h2>
<#isso-root>
<.postbox>
```
But that left the order of `#isso-root` and the `postbox`
wrong, the box was displayed *after* the comment list
The hotfix release 0.12.6.1:
861f64f "isso: js: embed: Insert Postbox before comments"
tried to rectify this, but it resulted in the following
state:
```
<#isso-thread>
<h2>
<#isso-root>
<.postbox>
```
This commit restores the state as it was:
```
<#isso-thread>
<h2>
<.postbox>
<#isso-root>
```
Note to future contributors: DOM polyfill `prepend()` will
insert the element before the first child, not before the
element itself!
We do not want to crash the whole app if a selector is not present.
Isso returns a JSON response with `total_replies=0` instead of a 404 since version 0.12.3 (see troubleshooting, PR isso-comments#565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
We do not want to crash the whole app if a selector is not present.
Isso returns a JSON response with
total_replies=0instead of a 404 since version 0.12.3 (see troubleshooting, PR Return 200 with empty array when there are no comments #301 #565)Why is this necessary?
State previously, on 0.12.5:
Then, because configs needed to be fetched before rendering the postbox because of: 02f3ea0
This was the state in 0.12.6:
But that left the order of
#isso-rootand thepostboxwrong, the box was displayed after the comment listThe hotfix release 0.12.6.1: 861f64f tried to rectify this, but it resulted in the following
state:
This commit restores the state as it was: