Return 200 with empty array when there are no comments #301 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{"id": null, "total_replies": 0, "hidden_replies": 0, "replies": []}
|
Please also update the tests. |
ix5
added a commit
to ix5/isso
that referenced
this pull request
Jan 17, 2021
Isso returns 200 instead of 404 since isso-comments#565
ix5
added a commit
to ix5/isso
that referenced
this pull request
Jan 19, 2021
Isso returns 200 instead of 404 since isso-comments#565
ix5
added a commit
to ix5/isso
that referenced
this pull request
May 25, 2022
Isso returns a JSON response with `total_replies=0` instead of a 404 since version 0.12.3 (see troubleshooting, PR isso-comments#565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of us who are picky about 404s, the API returns 404 when there are no comments. The not found exception was removed and the endpoint returns empty as expected with HTTP status 200.
{"id": null, "total_replies": 0, "hidden_replies": 0, "replies": []}