Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin, demo: Use trailing slashes for user-facing pages #900

Merged
merged 5 commits into from
Jun 5, 2022
Merged

admin, demo: Use trailing slashes for user-facing pages #900

merged 5 commits into from
Jun 5, 2022

Commits on Jun 5, 2022

  1. views: comments: Use /demo/, not /demo as endpoint 

    And also clean up URL to not contain `index.html`
    @ix5
    ix5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    b95b364 View commit details
    Browse the repository at this point in the history

  2. apidoc: Archive 0.12.6 /demo endpoint, bump apiVersion

    @ix5
    ix5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    8b4e9b1 View commit details
    Browse the repository at this point in the history

  3. views: Use trailing slashes for user-facing admin URLs 

    ```
/admin -> /admin/
/login  -> /login/
```

Since any non-API page can reasonably be expected to end in
a trailing slash by visitors (it is a path, not a file),
set the trailing slash version as canonical.

This has another positive side-effect:
Visiting `isso.dev/admin` (without trailing slash) will
redirect to `/admin/` automatically, thus obviating issues
like isso-comments#489 [^1]. Any Javascript or CSS files are not affected
as they are served throught the `SharedDataMiddleware` in
`__init__.py`` anyway.

[^1]: isso-comments#498
    @ix5
    ix5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    9d407a5 View commit details
    Browse the repository at this point in the history

  4. js: test/integration: Update snapshots, tests without index.html

    @ix5
    ix5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    9f417b6 View commit details
    Browse the repository at this point in the history

  5. js: test/screenshots: Remove index.html from jest expect

    @ix5
    ix5 committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    a48f62a View commit details
    Browse the repository at this point in the history