admin, demo: Use trailing slashes for user-facing pages #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also clean up URL to not contain `index.html`
``` /admin -> /admin/ /login -> /login/ ``` Since any non-API page can reasonably be expected to end in a trailing slash by visitors (it is a path, not a file), set the trailing slash version as canonical. This has another positive side-effect: Visiting `isso.dev/admin` (without trailing slash) will redirect to `/admin/` automatically, thus obviating issues like isso-comments#489 [^1]. Any Javascript or CSS files are not affected as they are served throught the `SharedDataMiddleware` in `__init__.py`` anyway. [^1]: isso-comments#498
ix5
added
server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
views: comments: Use /demo/, not /demo as endpoint
And also clean up URL to not contain
index.htmlAlso: apidoc: Archive 0.12.6 /demo endpoint, bump apiVersion
views: Use trailing slashes for user-facing admin URLs
Since any non-API page can reasonably be expected to end in a trailing slash by visitors (it is a path, not a file), set the trailing slash version as canonical.
This has another positive side-effect:
Visiting
isso.dev/admin(without trailing slash) will redirect to/admin/automatically, thus obviating issues like #489 1. Any Javascript or CSS files are not affected as they are served throught theSharedDataMiddlewarein `init.py`` anyway.Why is this necessary?
Was quite confusing to visit
/admin/and be hit with a 404.Footnotes
https://github.com/posativ/isso/issues/498 ↩