feat: Enable classProperties and classPrivateProperties parsers. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcoe I'd like to make sure this is in the |
coreyfarrell
commented
Apr 24, 2019
| /* Verify and add upon release of node.js 12: | ||
| * classProperties | ||
| * classPrivateProperties | ||
| * classPrivateMethods |
There was a problem hiding this comment.
It seems classPrivateMethods are not supported in node.js v12.0.0. Will be keeping an eye on the v8 release blog and add plugins when appropriate.
bcoe
reviewed
Apr 24, 2019
| } | ||
|
|
||
| export function isClassPrivatePropAvailable() { | ||
| return tryThis('class Foo { #a = 1; }', 'class private property'); |
There was a problem hiding this comment.
oh my goodness, I'm unreasonably excited about this feature.
bcoe
approved these changes
Apr 24, 2019
Yes in Chrome 74 and Node.js 12. Private getters/setters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.