Fix coverage.branchMap else location. #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Oct 4, 2021
bcoe
reviewed
Oct 4, 2021
| @@ -420,7 +420,7 @@ function coverIfBranches(path) { | |||
| if (ignoreElse) { | |||
| this.setAttr(n.alternate, 'skip-all', true); | |||
| } else { | |||
| this.insertBranchCounter(path.get('alternate'), branch, n.loc); | |||
| this.insertBranchCounter(path.get('alternate'), branch); | |||
There was a problem hiding this comment.
If I'm understanding correctly, does this end up using the column position of the alternate node, whereas before it was the start of the if?
There was a problem hiding this comment.
exactly,
before: the line and column was both at the start of the if.
after: line+col at the else. If no else/next alternate, then result is alternate locations[1]: {start: {}, end: {}}
thank you!!
Version # updated by the tooling. Co-authored-by: Benjamin E. Coe <bencoe@google.com>
bcoe
approved these changes
Oct 6, 2021
bcoe
approved these changes
Oct 6, 2021
|
@adrian-burlacu-software thank you for the contribution 👍 |
This was referenced Feb 8, 2022
vivek-freshworks
pushed a commit
to freshworks/istanbuljs
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The else statement in an if ... else statement is not correct.
Input code:
if (x) { output = x; } else { output = false; }Problem output:
branchMap: ..."1": { "loc": { "start": { "line": 7, "column": 2 }, "end": { "line": 12, "column": 3 } }, "type": "if", "locations": [{ "start": { "line": 7, "column": 2 }, "end": { "line": 12, "column": 3 } }, { "start": { "line": 7, // PROBLEM "column": 2 }, "end": { "line": 12, "column": 3 } } ], "line": 7 }Expected output:
branchMap: ..."1": { "loc": { "start": { "line": 7, "column": 2 }, "end": { "line": 12, "column": 3 } }, "type": "if", "locations": [{ "start": { "line": 7, "column": 2 }, "end": { "line": 12, "column": 3 } }, { "start": { "line": 10, // CORRECT "column": 7 }, "end": { "line": 12, "column": 3 } } ], "line": 7 }Caveats: Your testing code on fails to test the map properties, so I also omitted those tests because they are too far outside the scope of fixing this single bug. Cheerio to the team of my fave JavaScript coverage library.