Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage.branchMap else location. #633

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Fix coverage.branchMap else location. #633

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323d5af
Fix coverage.branchMap else location.
adrian-burlacu-software Sep 30, 2021
128364e
Oops, bump version!
adrian-burlacu-software Sep 30, 2021
f292abd
Update packages/istanbul-lib-instrument/package.json
adrian-burlacu-software Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/istanbul-lib-instrument/src/visitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ function coverIfBranches(path) {
if (ignoreElse) {
this.setAttr(n.alternate, 'skip-all', true);
} else {
this.insertBranchCounter(path.get('alternate'), branch, n.loc);
this.insertBranchCounter(path.get('alternate'), branch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding correctly, does this end up using the column position of the alternate node, whereas before it was the start of the if?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly,
before: the line and column was both at the start of the if.
after: line+col at the else. If no else/next alternate, then result is alternate locations[1]: {start: {}, end: {}}
thank you!!

}
}

Expand Down