feat: allow babel cache to be enabled #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks great. Simplicity 🔥 |
|
@Arturszott did you ever get a chance to try this out? You should be able to use it if you run:
|
jimthedev
pushed a commit
to commitizen/cz-cli
that referenced
this pull request
May 24, 2018
This Pull Request updates dependency [nyc](https://github.com/istanbuljs/nyc) from `v10.0.0` to `v10.3.2` <details> <summary>Release Notes</summary> ### [`v10.3.2`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1100httpsgithubcomistanbuljsnyccomparev1032v1100-2017-05-31) [Compare Source](istanbuljs/nyc@e062a86...v10.3.2) ##### Bug Fixes * add support for ES6 modules ([f18f780](istanbuljs/nyc@f18f780)) ##### Features * allow .nycrc.json ([#​580](`istanbuljs/nyc#580)) ([a1a457f](istanbuljs/nyc@a1a457f)) * upgrade to version of yargs with support for presets ([33829b8](istanbuljs/nyc@33829b8)) ##### BREAKING CHANGES * new version of find-up requires dropping 0.10/0.12 support (which we had already been planning). #### [10.3.2](istanbuljs/nyc@v10.3.1...v10.3.2) (2017-05-05) ##### Bug Fixes * we should not create a cache folder if cache is false ([#​567](`istanbuljs/nyc#567)) ([213206f](istanbuljs/nyc@213206f)) #### [10.3.1](istanbuljs/nyc@v10.3.0...v10.3.1) (2017-05-04) ##### Bug Fixes * introduced a bug that resulted in source-maps not being loaded approriately on second test run ([#​566](`istanbuljs/nyc#566)) ([1bf74fd](istanbuljs/nyc@1bf74fd)) --- ### [`v10.3.1`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1032httpsgithubcomistanbuljsnyccomparev1031v1032-2017-05-05) [Compare Source](istanbuljs/nyc@v10.3.0...v10.3.1) ##### Bug Fixes * we should not create a cache folder if cache is false ([#​567](`istanbuljs/nyc#567)) ([213206f](istanbuljs/nyc@213206f)) --- ### [`v10.3.0`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1030httpsgithubcomistanbuljsnyccomparev1020v1030-2017-04-29) [Compare Source](istanbuljs/nyc@55e826d...v10.3.0) ##### Bug Fixes * source-maps were not being cached in the parent process when --all was being used ([#​556](`istanbuljs/nyc#556)) ([ff73b18](istanbuljs/nyc@ff73b18)) ##### Features * add support for --no-clean, to disable deleting raw coverage output ([#​558](`istanbuljs/nyc#558)) ([1887d1c](istanbuljs/nyc@1887d1c)) --- ### [`v10.2.2`](istanbuljs/nyc@2ff8f3b...2ff8f3b) [Compare Source](istanbuljs/nyc@2ff8f3b...2ff8f3b) --- ### [`v10.2.1`](istanbuljs/nyc@v10.2.0...2ff8f3b) [Compare Source](istanbuljs/nyc@v10.2.0...2ff8f3b) --- ### [`v10.2.0`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1030httpsgithubcomistanbuljsnyccomparev1020v1030-2017-04-29) [Compare Source](istanbuljs/nyc@43535f9...v10.2.0) ##### Bug Fixes * source-maps were not being cached in the parent process when --all was being used ([#​556](`istanbuljs/nyc#556)) ([ff73b18](istanbuljs/nyc@ff73b18)) ##### Features * add support for --no-clean, to disable deleting raw coverage output ([#​558](`istanbuljs/nyc#558)) ([1887d1c](istanbuljs/nyc@1887d1c)) --- ### [`v10.1.2`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1012httpsgithubcomistanbuljsnyccomparev1011v1012-2017-01-18) [Compare Source](istanbuljs/nyc@e46335f...v10.1.2) ##### Bug Fixes * revert defaulting to empty file-coverage report, this caused too many issues ([25aec77](istanbuljs/nyc@25aec77)) --- ### [`v10.1.0`](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#​1020httpsgithubcomistanbuljsnyccomparev1010v1020-2017-03-28) [Compare Source](istanbuljs/nyc@8f7af3a...v10.1.0) ##### Bug Fixes * fix bug related to merging coverage reports see [#​482](`istanbuljs/nyc#482) ([81229a0](istanbuljs/nyc@81229a0)) * revert defaulting to empty file-coverage report, this caused too many issues ([25aec77](istanbuljs/nyc@25aec77)) ##### Features * allow babel cache to be enabled ([#​517](`istanbuljs/nyc#517)) ([98ebdff](istanbuljs/nyc@98ebdff)) * exclude the coverage/ folder by default 🚀 ([#​502](`istanbuljs/nyc#502)) ([50adde4](istanbuljs/nyc@50adde4)) * upgrade to version of yargs with extend support ([#​541](`istanbuljs/nyc#541)) ([95cc09a](istanbuljs/nyc@95cc09a)) #### [10.1.2](istanbuljs/nyc@v10.1.1...v10.1.2) (2017-01-18) ##### Bug Fixes * revert defaulting to empty file-coverage report, this caused too many issues ([25aec77](istanbuljs/nyc@25aec77)) #### [10.1.1](istanbuljs/nyc@v10.1.0...v10.1.1) (2017-01-18) ##### Bug Fixes * fix bug related to merging coverage reports see [#​482](`istanbuljs/nyc#482) ([81229a0](istanbuljs/nyc@81229a0)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
|
I have found this PR when debugging issue with nyc and babel What exactly is the problem with babel cache and nyc? I can't find a reference to any issues, only this PR :) no matter how much I look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the babel cache to be disabled, thanks for the patch @Arturszott.
In this pull I make one tiny tweak, the environment variable is now simply not set if you set
babel-cache=true.