Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn-wrap fails fails to shim node on Windows (part deux) #56

Closed
jasongardnerlv opened this issue Jun 6, 2017 · 3 comments
Closed

Comments

@jasongardnerlv
Copy link

see #43

The code change made for that issue is case sensitive and only fixes this for ".exe". I'm running on Windows 10 in babun/cygwin, and my error is:

Error: Cannot find module 'C:\Users\<username>\.node-spawn-wrap-99436-4aa667b29537\node.EXE' at Function.Module._resolveFilename (module.js:469:15) at Function.Module._load (module.js:417:25) at Module.runMain (module.js:604:10) at run (bootstrap_node.js:390:7) at startup (bootstrap_node.js:150:9) at bootstrap_node.js:505:3

Looks like path.basename itself is case-sensitive, so a different solution is necessary:
https://github.com/jinder/path/blob/master/path.js#L353

@mykmelez
Copy link

Looks like path.basename itself is case-sensitive, so a different solution is necessary:
https://github.com/jinder/path/blob/master/path.js#L353

That's an old version of the path module, but the latest version also looks case-sensitive (albeit without a comment questioning that behavior on Windows):

https://github.com/nodejs/node/blob/master/lib/path.js#L817-L904

@mykmelez
Copy link

I filed nodejs/node#13727 on the issue in Node.

@mykmelez
Copy link

@isaacs fixed this in fc98d38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants