Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: require Node 8 #78

Closed
wants to merge 1 commit into from
Closed

feat: require Node 8 #78

wants to merge 1 commit into from

Commits on May 9, 2019

  1. feat: require Node 8 

    ## Why

- Align with Node's support policy by targeting oldest LTS.
- Use promise-based APIs out-of-the box (without having to use bluebird)
- Remove workarounds for old Node versions
- Refactor the internals to use ES syntax (scoped variables, spread args, arrow functions, etc.)

Supporting unmaintained Node versions is proving to be an increasing burden as third party libraries drop support for it (e.g. `tap`). Using ES5 syntax while ES2015 brought a lot of improvements to the language is also a weight on maintenance. Finally, this is a pretty mild breaking change: there is no intent to break API compat. Since it implies a semver major update, it will be opt-in and only affect users explicitly updating their projects. The primary motivations for this PR is improving coverage tools using V8, a feature only present on modern Node versions anyway.

## What

- Update CI to run against the currently supported Node versions: Node 8, 10 and 12.
- Add `engines.node` field to `package.json` to warn users trying to use the library on an unmaintained Node version.
    @demurgos
    demurgos committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f2567e3 View commit details
    Browse the repository at this point in the history