feat: require Node 8 #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2018
profnandaa
approved these changes
Oct 20, 2018
|
Ping @bcoe |
Krinkle
approved these changes
Jan 3, 2019
|
@martinheidegger unfortunately this is already a bit dated, I think we should update the pull request to |
|
With Node dropping support for Node 6, I updated my PR to use Node 8, 10 and 12. |
## Why - Align with Node's support policy by targeting oldest LTS. - Use promise-based APIs out-of-the box (without having to use bluebird) - Remove workarounds for old Node versions - Refactor the internals to use ES syntax (scoped variables, spread args, arrow functions, etc.) Supporting unmaintained Node versions is proving to be an increasing burden as third party libraries drop support for it (e.g. `tap`). Using ES5 syntax while ES2015 brought a lot of improvements to the language is also a weight on maintenance. Finally, this is a pretty mild breaking change: there is no intent to break API compat. Since it implies a semver major update, it will be opt-in and only affect users explicitly updating their projects. The primary motivations for this PR is improving coverage tools using V8, a feature only present on modern Node versions anyway. ## What - Update CI to run against the currently supported Node versions: Node 8, 10 and 12. - Add `engines.node` field to `package.json` to warn users trying to use the library on an unmaintained Node version.
|
Travis and Appveyor have some issues since I update to require Node 8 instead of Node 6. I'll try sending a new PR. |
Merged
|
Closing in favor of #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Supporting unmaintained Node versions is proving to be an increasing burden as third party libraries drop support for it (e.g.
tap). Using ES5 syntax while ES2015 brought a lot of improvements to the language is also a weight on maintenance. Finally, this is a pretty mild breaking change: there is no intent to break API compat. Since it implies a semver major update, it will be opt-in and only affect users explicitly updating their projects. The primary motivations for this PR is improving coverage tools using V8, a feature only present on modern Node versions anyway.What
engines.nodefield topackage.jsonto warn users trying to use the library on an unmaintained Node version./cc @bcoe @profnandaa