Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting CEPH_KEYRING from an option rather than an envvar #79

Open
olorin opened this issue Feb 19, 2015 · 1 comment
Open

Allow setting CEPH_KEYRING from an option rather than an envvar #79

olorin opened this issue Feb 19, 2015 · 1 comment

Comments

@olorin
Copy link
Contributor

olorin commented Feb 19, 2015

It's unintuitive to require runtime configuration with both CLI options and envvars (particularly as the latter aren't mentioned in the output of vault --help). Work out how to specify the Ceph keyring based on an option to the vault binary (may have to do this for inspect as well?). If there's no better way, we can just call setEnv with the provided value before we pass control to the command daemon.
@olorin olorin mentioned this issue Feb 19, 2015
Merged
olorin added a commit that referenced this issue Feb 19, 2015
@olorin
Add keyring option to vault program to set the CEPH_KEYRING envvar
6788049 
So we don't have runtime behavior dependent on a mix of CLI options and
environment variables.

Fixes GitHub issue #79.
olorin added a commit that referenced this issue Feb 19, 2015
@olorin
Add ceph-keyring option to vault program to set the CEPH_KEYRING envvar
3046f66 
So we don't have runtime behavior dependent on a mix of CLI options and
environment variables.

Fixes GitHub issue #79.
@olorin olorin mentioned this issue Feb 19, 2015
Merged
@istathar
Copy link
Owner

Brilliant @fractalcat I'm glad you took this on.

(may have to do this for inspect as well?)

I daresay, yes.

AfC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olorin @istathar