Add keyring option to vault program to set the CEPH_KEYRING envvar #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we don't have runtime behavior dependent on a mix of CLI options and environment variables. Fixes GitHub issue #79.
| ## User interface | ||
|
|
||
| * The `CEPH_KEYRING` environment variable no longer needs to be manually | ||
| specified; it can be passed in as the `--ceph-keyring` command-line |
There was a problem hiding this comment.
Does it need ceph-? We don't make the "user" specify --ceph-username and --ceph-pool.
There was a problem hiding this comment.
Perhaps not. I had it like that originally, can't remember why I changed it. Will update.
|
Build actually passing, in spite of claims to the contrary. https://travis-ci.org/anchor/vaultaire/builds/51765768 |
istathar
added a commit
that referenced
this pull request
Feb 23, 2015
Add a --keyring option to vault program to set the CEPH_KEYRING environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't have runtime behavior dependent on a mix of CLI options and
environment variables.
Fixes GitHub issue #79.