Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from vendor to go modules #32

Closed
aattuluri opened this issue Oct 15, 2019 · 6 comments
Closed

Switch from vendor to go modules #32

aattuluri opened this issue Oct 15, 2019 · 6 comments
Assignees
@nickborysov
Labels
hacktoberfest issue open for hackoberfest contribution

Comments

@aattuluri
Copy link
Contributor

Currently, admiral project uses vendor for its dependencies. Switch to go modules for better dependency management.
@aattuluri aattuluri added the hacktoberfest issue open for hackoberfest contribution label Oct 15, 2019
@vdepatla
Copy link

I can take on this one ..

@aattuluri
Copy link
Contributor Author

@vdepatla Sounds good. I will look forward for a PR.

@nickborysov
Copy link
Contributor

@aattuluri #36

@aattuluri
Copy link
Contributor Author

@vdepatla #36 looks good to me. I will go ahead and merge this, let me know if you think otherwise.

@vdepatla
Copy link

sure Thanks

@vdepatla vdepatla removed their assignment Oct 21, 2019
@aattuluri
Copy link
Contributor Author

Solved with #36

itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
MESH-461 triggering docs pipeline (istio-ecosystem#32)
ae52c40 
* MESH-461 triggering docs pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickborysov nickborysov

Labels
hacktoberfest issue open for hackoberfest contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickborysov @vdepatla @aattuluri