fix for concurrent map iteration and map write #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shriramsharma
force-pushed
the
fix-concurrent-map-access
branch
from
1a964f1
to
b478504
Compare
aattuluri
approved these changes
Mar 14, 2022
Added `.Range()` and `.Copy() func to avoid concurrent map read and write. Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
shriramsharma
force-pushed
the
fix-concurrent-map-access
branch
from
b8474bd
to
50e7679
Compare
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
* fixes istio-ecosystem#196 Added `.Range()` and `.Copy() func to avoid concurrent map read and write. Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com> * fixed the linting errors Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com> Co-authored-by: Shriram Sharma <shriram_sharma@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196
Added
.Range()and.Copy()func to avoid concurrent map read andwrite.