Support for BlueGreen rollout preview endpoint #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 16, 2022 18:33
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
asushanthk
reviewed
Mar 18, 2022
added 2 commits
March 18, 2022 17:45
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
added 2 commits
March 25, 2022 09:01
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
aattuluri
requested changes
Mar 29, 2022
Signed-off-by: nbn01 <nandan_bn@intuit.com>
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
from
c36fb50
to
50c0ce5
Compare
added 2 commits
March 31, 2022 20:02
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
from
5a2e8b7
to
c97ed13
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 74.42% 75.02% +0.60%
==========================================
Files 26 26
Lines 2530 2567 +37
==========================================
+ Hits 1883 1926 +43
+ Misses 516 512 -4
+ Partials 131 129 -2
Continue to review full report at Codecov.
|
aattuluri
requested changes
Apr 4, 2022
|
@itsLucario There are lint errors, fix them before we can merge. |
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
2 times, most recently
from
bac0a2b
to
c97ed13
Compare
Signed-off-by: nbn01 <nandan_bn@intuit.com>
golangci-lint was using go1.18 that caused the panic. I added a fix to the workflow to use go1.17.7. |
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com>
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Admiral generates endpoint for Rollouts with bluegreen it always uses active/stable service as destination. This PR will adds a feature to generate an additional mesh endpoint that would point to the preview service of the blugreen stack.