[bug] prevent panic when finding out rollout strategy #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
…m#210) * prevent panic when finding out rollout strategy Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com>
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
…m#210) * prevent panic when finding out rollout strategy Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* prevent panic when finding out rollout strategy Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com> Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
* Tune default outlier detection parameters for remote endpoints (istio-ecosystem#207) * [bug] prevent panic when finding out rollout strategy (istio-ecosystem#210) * prevent panic when finding out rollout strategy Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com> * Optimize GlobalTrafficPolicy fetching and endpoint generation time (istio-ecosystem#206) Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com> Co-authored-by: Anubhav <anubhavaeron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Argo rollouts can be defined without any rollout strategy. When this happens admiral panics because the code was fetch the Strategy when Strategy was empty.