Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune default outlier detection parameters for remote endpoints #207

Merged

Conversation

aattuluri
Copy link
Contributor

@aattuluri aattuluri commented Apr 19, 2022

Context: #205

Change 1: Switching from consecutive5xxErrors to consecutiveGatewayErrors (to exclude 500s returned by upstream)
Change 2: Set max ejection percent to 100% to trigger failover to the other region when endpoints start having issues.

//Scenario 1: Only one endpoint present and is local service (ends in svc.cluster.local) - no outlier detection (optimize this for headless services in future?)
//Scenario 2: Only one endpoint present and is remote - outlier detection with 34% ejection (protection against zone specific issues)
//Scenario 3: Two endpoints present each with different locality and both remote - outlier detection with 100% ejection
//Scenario 4: Two endpoints present each with different locality with one local and other remote - outlier detection with 100% ejection
//Scenario 5: for service entries with more than 2 endpoints eject 100% to failover to other endpoint within or outside the same region

Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
@aattuluri aattuluri added the WIP Work In Progress label Apr 19, 2022
@aattuluri aattuluri removed the WIP Work In Progress label Apr 21, 2022
@aattuluri aattuluri merged commit ecc771e into istio-ecosystem:master May 2, 2022
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 15, 2022
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
* Tune default outlier detection parameters for remote endpoints (istio-ecosystem#207)

* [bug] prevent panic when finding out rollout strategy (istio-ecosystem#210)

* prevent panic when finding out rollout strategy
Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com>

* Optimize GlobalTrafficPolicy fetching and endpoint generation time (istio-ecosystem#206)

Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Co-authored-by: Anubhav <anubhavaeron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants