Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to globaltrafficpolicy cache cleanup #215

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

vrushalijoshi
Copy link
Collaborator

Fixing bug with globaltrafficpolicy cache cleanup, once GTP associated with an identity is deleted.

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
@vrushalijoshi vrushalijoshi requested review from asushanthk and removed request for asushanthk May 9, 2022 22:26
@codecov-commenter
Copy link

Codecov Report

Merging #215 (aa676ca) into master (35de918) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files          27       27           
  Lines        2535     2535           
=======================================
  Hits         1884     1884           
  Misses        528      528           
  Partials      123      123           
Impacted Files Coverage Δ
admiral/pkg/clusters/serviceentry.go 81.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35de918...aa676ca. Read the comment docs.

@aattuluri aattuluri merged commit c57f8a5 into master Jun 16, 2022
@aattuluri aattuluri deleted the fix-gtp-cache-cleanup-bug branch June 16, 2022 17:54
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants