Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the failing GTP test #231

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

shriramsharma
Copy link
Collaborator

The GTP cache test was failing intermittently since the test was dependent on the order in which the map returned the GTPs.

Signed-off-by: Shriram Sharma shriram_sharma@intuit.com

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shriramsharma shriramsharma merged commit d8b06cb into istio-ecosystem:master Jun 17, 2022
@shriramsharma shriramsharma deleted the fixed_gtp_tests branch June 17, 2022 00:10
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants