Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor service to deploy/rollout matching #239

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

aattuluri
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #239 (fd1e83b) into master (eeefffa) will decrease coverage by 0.42%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   74.22%   73.79%   -0.43%     
==========================================
  Files          27       27              
  Lines        2630     2633       +3     
==========================================
- Hits         1952     1943       -9     
- Misses        558      570      +12     
  Partials      120      120              
Impacted Files Coverage Δ
admiral/pkg/controller/common/common.go 76.04% <0.00%> (-10.87%) ⬇️
admiral/pkg/clusters/handler.go 60.55% <100.00%> (-0.92%) ⬇️
admiral/pkg/controller/admiral/deployment.go 87.09% <100.00%> (+0.28%) ⬆️
admiral/pkg/controller/admiral/rollouts.go 82.00% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeefffa...fd1e83b. Read the comment docs.

Copy link
Collaborator

@itsLucario itsLucario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aattuluri aattuluri merged commit 808976e into master Jul 5, 2022
@aattuluri aattuluri deleted the Fix-service-matching branch July 5, 2022 06:12
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
) (istio-ecosystem#137)

Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants