generate additional endpoints based on labels set on deployments or rollouts #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollouts Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
nirvanagit
reviewed
Mar 7, 2023
| expectedResult: true, | ||
| }, | ||
| { | ||
| name: "Given additional endpoint suffixes and labels, when additional endpoint labels filters contains is not in the rollout/deployment annotation, then the func should return false", |
There was a problem hiding this comment.
Suggested change
| name: "Given additional endpoint suffixes and labels, when additional endpoint labels filters contains is not in the rollout/deployment annotation, then the func should return false", | |
| name: "Given additional endpoint suffixes and labels, when additional endpoint label filters do not include any key in labels, then it should return false", |
nirvanagit
reviewed
Mar 7, 2023
| expectedResult: false, | ||
| }, | ||
| { | ||
| name: "Given additional endpoint suffixes and labels, when additional endpoint labels filters contains the rollout/deployment annotation, then the func should return true", |
There was a problem hiding this comment.
Suggested change
| name: "Given additional endpoint suffixes and labels, when additional endpoint labels filters contains the rollout/deployment annotation, then the func should return true", | |
| name: "Given additional endpoint suffixes and labels, when additional endpoint labels filters contains one of the keys in the labels, then it should return true", |
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
nirvanagit
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.