Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale descriptions #2247

Closed
wants to merge 2 commits into from
Closed

Update stale descriptions #2247

wants to merge 2 commits into from

Conversation

ktalg
Copy link

@ktalg ktalg commented Feb 11, 2022

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2022
@istio-testing
Copy link
Collaborator

Hi @ktalg. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link
Contributor

ericvn commented Feb 11, 2022

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 11, 2022
@ericvn
Copy link
Contributor

ericvn commented Feb 11, 2022

A make gen is needed.

@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@ktalg
Copy link
Author

ktalg commented Feb 12, 2022

/retest

@ktalg
Copy link
Author

ktalg commented Feb 12, 2022

@ktalg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
release-notes_api d5a2a3d link false /test release-notes_api

@ericvn
It seems that a release-notes-none is needed.

@ericvn
Copy link
Contributor

ericvn commented Feb 14, 2022

Related to #2216

Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericvn ericvn added the release-notes-none Indicates a PR that does not require release notes. label Mar 16, 2022
@ericvn
Copy link
Contributor

ericvn commented Mar 16, 2022

/test release-notes_api

@ericvn
Copy link
Contributor

ericvn commented Mar 16, 2022

Looking through the referenced PRs and some other PRs, I'm not sure this is accurate. @howardjohn probably has the most knowledge of the gateway/sidecar settings noted here.

@ktalg ktalg closed this by deleting the head repository Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProxyConfig.concurrency documentation is unclear
5 participants