Skip to content
This repository has been archived by the owner on Jan 23, 2022. It is now read-only.

Remove namespace from clusterrole and clusterrolebinding #297

Merged
merged 1 commit into from Apr 14, 2020

Conversation

aaronjwood
Copy link

Cluster roles and cluster role bindings are cluster-wide and not namespace specific. We had a case where this broke installation for us due to some client-go code throwing back a not found error (https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go#L122) when trying to create these two resources in the cluster. Taking out the namespace (which is set to kube-system after the template is instantiated) for the cluster-wide resources got everything to work correctly.

@aaronjwood aaronjwood requested a review from a team April 14, 2020 21:02
@istio-policy-bot
Copy link

😊 Welcome @aaronjwood! This is either your first contribution to the Istio cni repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 14, 2020
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Apr 14, 2020
@istio-testing
Copy link
Contributor

Hi @aaronjwood. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@venilnoronha venilnoronha added cherrypick/release-1.4 Set this label on a PR to auto-merge it to the release-1.4 branch cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch labels Apr 14, 2020
@venilnoronha
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 14, 2020
@istio-testing istio-testing merged commit e124447 into istio:release-1.4 Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherrypick/release-1.4 Set this label on a PR to auto-merge it to the release-1.4 branch cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
6 participants