This repository has been archived by the owner on Jan 23, 2022. It is now read-only.
Remove namespace from clusterrole and clusterrolebinding #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster roles and cluster role bindings are cluster-wide and not namespace specific. We had a case where this broke installation for us due to some client-go code throwing back a not found error (https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go#L122) when trying to create these two resources in the cluster. Taking out the namespace (which is set to
kube-system
after the template is instantiated) for the cluster-wide resources got everything to work correctly.