Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design doc template link. #217

Merged
merged 2 commits into from Sep 4, 2019
Merged

Update design doc template link. #217

merged 2 commits into from Sep 4, 2019

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Aug 30, 2019

  • And add Piotr Sikora as a networking WG lead.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 30, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2019
Copy link
Contributor

@smawson smawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW some other changes in here but they're all fine. Maybe change title/description of the PR to include all the changes (adding Piotr, updating CODEOWNERS).

@@ -57,7 +57,7 @@ Anybody can access the team drive for reading and commenting. To get access simp
Once you've done that, head to [Team Drive](https://drive.google.com/corp/drive/u/0/folders/0AIS5p3eW9BCtUk9PVA) and
behold all the docs.

We have a common [design document template](https://docs.google.com/document/d/1cpolPNH_RtSobUjTkXyyxsCJT7EKD8fGiN2TgYLeJu8/edit#heading=h.7zgnj8bwqfld).
We have a common [design document template](https://docs.google.com/document/d/16FLQK8uhhic1ovKnnOG3OXJjFKs2aHnSmbximidpKwM/edit).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: Why didn't we just update the existing doc? In any event we should only have one "design doc template" in the drive, so if we have a new doc make sure to delete the old one.

@istio-testing istio-testing merged commit 07ea16e into istio:master Sep 4, 2019
oaktowner pushed a commit to oaktowner/community that referenced this pull request Jul 7, 2020
* Update design doc template link.

* Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants