Overall update and cleanup. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
reviewed
Mar 19, 2018
| @@ -48,7 +48,8 @@ permission to use and redistribute your contributions as part of the project. | |||
| Any substantial design deserves a design document. Design documents are written with Google Docs and | |||
| should be shared with the community by adding the doc to our [Team Drive](https://drive.google.com/corp/drive/u/0/folders/0AIS5p3eW9BCtUk9PVA) | |||
| and sending a note to the appropriate working group to let people know the doc is there. To get write access | |||
| to the drive, you'll need to be a [member](ROLES.md#member) of the Istio organization. | |||
| to the drive, you'll need to be a [member](ROLES.md#member) of the Istio organization, but anybody can read and | |||
There was a problem hiding this comment.
According to the dictionary, these are interchangeable terms, so leaving as-is.
CONTRIBUTING.md
Outdated
| @@ -126,16 +135,19 @@ When ready, if you have not already done so, sign a | |||
| the PR. | |||
|
|
|||
| See [Reviewing and Merging Pull Requests for Istio](REVIEWING.md) for the PR review and | |||
| merge process that is used by the maintainers of the project. | |||
| merge process that we use. | |||
|
|
|||
| ## Issues | |||
|
|
|||
| GitHub issues can be used to report bugs or submit feature requests. | |||
|
|
|||
| When reporting a bug please include the following key pieces of information: | |||
There was a problem hiding this comment.
this should probably point to or mirror
https://github.com/istio/issues/issues/new
ROLES.md
Outdated
|
|
||
| * Primary reviewer for at least 10 substantial PRs to the codebase | ||
| * Merged at least 30 substantial PRs to the codebase |
There was a problem hiding this comment.
merged is ambiguous, I think you mean authored but could be (mis)interpreted as clicked the squash&merge button. Also depending on your definition of "substantial", has anyone done 30 substantial PRs ? (aka 30 features)
There was a problem hiding this comment.
Switched to "Contributed"
ldemailly
reviewed
Mar 19, 2018
ROLES.md
Outdated
| @@ -153,7 +153,7 @@ The following apply to the part of the codebase for which one would be an approv | |||
|
|
|||
| * Member for at least 3 months | |||
|
|
|||
| * Merged at least 30 substantial PRs to the codebase | |||
| * Contributed at least 30 substantial PRs to the codebase | |||
|
Ping... |
ldemailly
approved these changes
Mar 20, 2018
|
Ping. |
linsun
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.