Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote authz dry-run to alpha #112

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

yangminzhu
Copy link
Contributor

No description provided.

@yangminzhu yangminzhu requested review from a team as code owners December 3, 2021 23:32
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 3, 2021
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 3, 2021
@yangminzhu
Copy link
Contributor Author

@istio/technical-oversight-committee could someone help take a look the PR? thanks.

@louiscryan
Copy link

Is the user-feedback on the feature captured somewhere ?

@yangminzhu
Copy link
Contributor Author

Is the user-feedback on the feature captured somewhere ?

@louiscryan

I think we do not have much written feedback on this feature. We do have some customers asking questions like "how to roll out authorization policies in WARN mode before enforcing" in the slack channel and we pointed them to the dry-run task (https://preliminary.istio.io/latest/docs/tasks/security/authorization/authz-dry-run/) which they later confirmed it is exactly what they are looking for.

@louiscryan
Copy link

louiscryan commented Dec 11, 2021 via email

@smawson
Copy link
Contributor

smawson commented Dec 15, 2021

I'm fine with this progressing as well, do we need a TOC discussion or just approve it here? I do see some items still waiting on PRs to be submitted though so those should go in and be updated here.

@howardjohn
Copy link
Member

+1 from me as well

@nrjpoddar
Copy link
Member

LGTM

@Xunzhuo
Copy link
Member

Xunzhuo commented Dec 18, 2021

LGTM from me too.

@yangminzhu
Copy link
Contributor Author

@louiscryan @smawson @howardjohn @howardjohn Thanks for the review!

I have updated the PR for the remaining items, the other API PR has been merged and I have also sent the release note PR (istio/istio#36581), Please feel free to approve or let me know if you have other questions.

@yangminzhu
Copy link
Contributor Author

@louiscryan @smawson @howardjohn @howardjohn could you approve the PR now? Thanks.

@nrjpoddar
Copy link
Member

LGTM

@istio-testing istio-testing merged commit 97fab20 into istio:master Jan 11, 2022
@yangminzhu yangminzhu deleted the dry-run-alpha branch January 12, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants