Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

add workloads config to kiali #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add workloads config to kiali #548

wants to merge 1 commit into from

Conversation

yacut
Copy link

@yacut yacut commented Nov 12, 2019

related to istio/istio#18819

@yacut yacut requested a review from a team as a code owner November 12, 2019 09:02
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 12, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2019
@istio-testing
Copy link

Hi @yacut. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

morvencao
morvencao reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 19, 2019
@istio-testing
Copy link

@yacut: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_installer 1e4790b link /test lint_installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 19, 2019
@jmazzitelli
incorporate the changes that are made in
031ebe9 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
@jmazzitelli
Copy link
Member

jmazzitelli commented Nov 19, 2019 •
edited

same change has been made in the PR #556 that moves to the Kiali operator.

jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 19, 2019
@jmazzitelli
incorporate the changes that are made in
3505879 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 20, 2019
@jmazzitelli
incorporate the changes that are made in
77b0054 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
@sdake
Copy link
Member

sdake commented Nov 25, 2019

@yacut I am not really sure what this does. Similar in vein to the comments here #546 (comment) I think we should get out of the third party install business and into the third party integration business (via their operators).

Cheers
-steve

@jmazzitelli
Copy link
Member

jmazzitelli commented Nov 25, 2019 •
edited

FWIW: I have included this in the kiali operator integration PR: https://github.com/istio/installer/pull/556/files#diff-d2ae3febaa0204735dffb73c835471ddR88-R91

So the kiali operator integration will have the ability for the user to tell kiali which types of workloads to ignore.

We can close this PR once those kiali operator PRs are merged since this PR will not be relevant anymore.

jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 27, 2019
@jmazzitelli
incorporate the changes that are made in
497710b 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morvencao morvencao morvencao left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@yacut @istio-testing @jmazzitelli @sdake @morvencao @googlebot