Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kiali and add workloads config #18819

Closed
wants to merge 3 commits into from
Closed

Update kiali and add workloads config #18819

wants to merge 3 commits into from

Conversation

yacut
Copy link
Contributor

@yacut yacut commented Nov 9, 2019 •
edited by istio-policy-bot

Related to kiali/kiali#1903

@yacut yacut requested a review from a team as a code owner November 9, 2019 10:04
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 9, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 9, 2019
@istio-testing
Copy link
Collaborator

Hi @yacut. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmazzitelli
Copy link
Member

just FYI: we already moved up to Kiali v1.9 in both helm and istioctl installer for the Istio 1.4 release. And note this PR is only for the (soon to be deprecated) helm charts. Similar changes would need to be made in the istio/installer kiali charts.

@yacut yacut mentioned this pull request Nov 12, 2019
Open
jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 19, 2019
@jmazzitelli
incorporate the changes that are made in
031ebe9 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
@jmazzitelli jmazzitelli mentioned this pull request Nov 19, 2019
Closed
jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 19, 2019
@jmazzitelli
incorporate the changes that are made in
3505879 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 20, 2019
@jmazzitelli
incorporate the changes that are made in
77b0054 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
jmazzitelli added a commit to jmazzitelli/installer that referenced this pull request Nov 27, 2019
@jmazzitelli
incorporate the changes that are made in
497710b 
PR istio#548
for issue istio/istio#18819
by adding excludedWorkloads
@sdake
Copy link
Member

sdake commented Nov 30, 2019

@yacut thank you for your PR. We are in the process of standardizing install on the Kiali operator rather than our own home-grown installation technique. Also this directory is deprecated and replaced by https://github.com/istio/installer. Please see PR: #istio/operator#622 for more details.

Cheers
-steve

@howardjohn
Copy link
Member

Closing per above comment

@howardjohn howardjohn closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yacut @istio-testing @jmazzitelli @sdake @howardjohn @googlebot @istio-policy-bot