[release-1.4] update telemetryv2 templates #591
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/L
| @@ -1,5 +1,234 @@ | |||
| {{- if and .Values.telemetry.enabled .Values.telemetry.v2.enabled }} | |||
| {{ .Files.Get "metadata-exchange-v2.yaml" }} | |||
| apiVersion: networking.istio.io/v1alpha3 | |||
There was a problem hiding this comment.
This should be enabled if either stackdriver or prom is enabled.
There was a problem hiding this comment.
then there is no meaning of the v2.enabled setting? also if we have some more other filters in the future then this check would become lengthy
There was a problem hiding this comment.
Ok, that makes sense, this is only enabled when v2 is enabled .
|
/test noauth_installer_release-1.4 |
|
/retest |
1 similar comment
|
/retest |
|
We need to have 1.4 have this, and master have 1.5+1.4. Otherwise when we upgrade its just going to prune this one, right? |
|
@howardjohn yes I updated the master PR as well: #590. Plz check |
|
@howardjohn plz check again? |
|
@richardwxn can we merge master first so we ensure they are in sync? And have telemetry experts approve that one and I will merge |
richardwxn
changed the title
This change is for 1.4 specifically, including the filter part, proxymatch verison part