-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ServiceEntry example in concepts/traffic-management #11398
Conversation
This change replaces the incorrect mTLS egress example with a simpler, valid example that adjusts the TCP connection timeout. Page: Documentation / Concepts / Traffic Management Section: Service entry example URL: https://istio.io/latest/docs/concepts/traffic-management/#service-entry-example
Hi @merusso. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Good catch, LGTM. /ok-to-test |
@istio/wg-networking-maintainers Would you review this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Change back to v1alpha3 to be consistent with rest of page Co-authored-by: John Howard <howardjohn@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherrypick release-1.14
Fixes issue #11396.
This change replaces the incorrect mTLS egress example with a simpler,
valid example that adjusts the TCP connection timeout.
Page: Documentation / Concepts / Traffic Management
Section: Service entry example
URL: https://istio.io/latest/docs/concepts/traffic-management/#service-entry-example