Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceEntry example in concepts/traffic-management #11398

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fix ServiceEntry example in concepts/traffic-management #11398

merged 2 commits into from
Jun 15, 2022

Conversation

merusso
Copy link
Contributor

@merusso merusso commented Jun 10, 2022

Fixes issue #11396.

This change replaces the incorrect mTLS egress example with a simpler,
valid example that adjusts the TCP connection timeout.

Page: Documentation / Concepts / Traffic Management
Section: Service entry example
URL: https://istio.io/latest/docs/concepts/traffic-management/#service-entry-example

  • Docs

This change replaces the incorrect mTLS egress example with a simpler,
valid example that adjusts the TCP connection timeout.

Page: Documentation / Concepts / Traffic Management
Section: Service entry example
URL: https://istio.io/latest/docs/concepts/traffic-management/#service-entry-example
@merusso merusso requested a review from a team as a code owner June 10, 2022 23:46
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2022
@istio-testing
Copy link
Contributor

Hi @merusso. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@craigbox
Copy link
Contributor

Good catch, LGTM.
Will ask a WG member to check also.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 12, 2022
@merusso merusso changed the title Fix ServiceEntry example in concepts/traffic-management (#11396) Fix ServiceEntry example in concepts/traffic-management Jun 13, 2022
@ericvn
Copy link
Contributor

ericvn commented Jun 14, 2022

@istio/wg-networking-maintainers Would you review this PR. Thanks.

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

content/en/docs/concepts/traffic-management/index.md Outdated Show resolved Hide resolved
Change back to v1alpha3 to be consistent with rest of page

Co-authored-by: John Howard <howardjohn@google.com>
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherrypick release-1.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants