make helm install consistent with istioctl #11762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
zirain
added
cherrypick/release-1.14
and removed
size/S
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
istio-testing
added
size/S
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
|
Any feedback from @istio/wg-environments-maintainers ? |
howardjohn
requested changes
Aug 28, 2022
|
I also got some feedback same as istio/istio#39049 mentioned, the helm doc is different from istioctl, which confused istio rookie. |
|
If they are confused we should improve documentation, etc. Not proliferate
bad practices
…On Mon, Aug 29, 2022 at 5:29 AM zirain ***@***.***> wrote:
I also got some feedback same as istio/istio#39049
<istio/istio#39049> mentioned, the helm doc is
different from istioctl, which confused istio rookie.
—
Reply to this email directly, view it on GitHub
<#11762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXJLOD2ZJ4XC2UKWAV3V3SULRANCNFSM57YSAZ7A>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make helm install consistent with istioctl
fixes: istio/istio#39049
cc @frankbu