Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default monitoring port #3183

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Jan 31, 2019

Documentation updates that coincide with istio/istio#11421 which changed the default monitoring port from 9093 to 15014.

WIP until that PR is merged.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 31, 2019
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericvn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rcaballeromx

If they are not already assigned, you can assign the PR to them by writing /assign @rcaballeromx in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Contributor

Hi @ericvn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GregHanson
Copy link
Member

/ok-to-test

@ericvn
Copy link
Contributor Author

ericvn commented Jan 31, 2019

/assign @rcaballeromx

@rcaballeromx
Copy link
Contributor

@geeknoid Should we update the ports on the HTML of the reference guide or should the update take place in the code?

@rcaballeromx
Copy link
Contributor

/hold

@geeknoid
Copy link
Contributor

geeknoid commented Feb 2, 2019

All the changes in docs/reference should be removed from this PR. The changes need to happen in the source code and they'll be reflected in the doc repo next time I run the grabReferenceDocs script.

@ericvn
Copy link
Contributor Author

ericvn commented Feb 13, 2019

Per @geeknoid I removed the docs/reference file changes from this PR - Done

@ericvn ericvn changed the title [WIP] Change default monitoring port Change default monitoring port Feb 13, 2019
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 13, 2019
@ericvn
Copy link
Contributor Author

ericvn commented Feb 13, 2019

Removed the [WIP] since the underlying istio/istio#11421 was merged.

@geeknoid geeknoid merged commit 7a2f811 into istio:master Feb 13, 2019
@ericvn ericvn deleted the updateMonitorPort branch February 13, 2019 19:53
@ericbuehl ericbuehl mentioned this pull request Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants