-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default monitoring port #3183
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ericvn If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ericvn. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @rcaballeromx |
@geeknoid Should we update the ports on the HTML of the reference guide or should the update take place in the code? |
/hold |
All the changes in docs/reference should be removed from this PR. The changes need to happen in the source code and they'll be reflected in the doc repo next time I run the grabReferenceDocs script. |
9bc6c7b
to
9420a20
Compare
Per @geeknoid I removed the docs/reference file changes from this PR - Done |
Removed the [WIP] since the underlying istio/istio#11421 was merged. |
Documentation updates that coincide with istio/istio#11421 which changed the default monitoring port from 9093 to 15014.
WIP until that PR is merged.