Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/10514/15014/ #5260

Merged
merged 1 commit into from
Nov 12, 2019
Merged

s/10514/15014/ #5260

merged 1 commit into from
Nov 12, 2019

Conversation

ericbuehl
Copy link
Contributor

@ericbuehl ericbuehl commented Oct 26, 2019 •
edited by istio-policy-bot
Loading

Admittedly this is a naive suggestion as I don't know the history of port 10514. Perhaps it used to be used for something? However, in all the instances I found it seems to just be a typo that should really refer to port 15014.

@ericbuehl ericbuehl requested review from a team as code owners October 26, 2019 19:34
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 26, 2019
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Oct 26, 2019
@istio-testing
Copy link
Contributor

Hi @ericbuehl. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericbuehl
Copy link
Contributor Author

On closer investigation, this does indeed appear to be a typo introduced when the port changed from 9093 -> 15014 via #3183 and #3184

@ericvn
Copy link
Contributor

ericvn commented Oct 28, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 28, 2019
@geeknoid
Copy link
Contributor

Hi, could you please rebase this PR so we can merge it?

Thanks.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2019
@geeknoid geeknoid merged commit ad1020b into istio:master Nov 12, 2019
niceforbear pushed a commit to niceforbear/istio.io that referenced this pull request Nov 25, 2019
@ericbuehl @niceforbear
s/10514/15014/ (istio#5260)
c100654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@geeknoid geeknoid geeknoid approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ericbuehl @istio-testing @ericvn @geeknoid @howardjohn @googlebot @istio-policy-bot