Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text blocks. #3727

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Improve text blocks. #3727

merged 1 commit into from
Mar 18, 2019

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Mar 17, 2019

  • Add tests for the various text block features.

  • Combine text_file and text_dynamic into text_import

  • Add support for snippet extraction for text downloaded from a URL

  • Add support for formatting output blocks in a different style for
    content downloaded from a URL

  • Report some errors when unable to fetch content from a URL.

  • Fixed a few small bugs along the way.

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid geeknoid requested review from sdake and removed request for linsun, rootsongjc and rcaballeromx March 17, 2019 20:04
@geeknoid
Copy link
Contributor Author

@sdake I know you can't review the JavaScript and Hugo changes, but if you could browse the site and make sure text blocks look as they should, that'd be appreciated.

@geeknoid
Copy link
Contributor Author

BTW, the intent for this work is to get things fully ready for Code Mauve work, where we want to test all the examples in the site. Now, we'll be able to pull content & snippets from either local files or URLs, all with the same features as we use with inlined content.

- Add texts for the various text block features.

- Combine text_file and text_dynamic into text_import

- Add support for snippet extraction for text downloaded from a URL

- Add support for formatting output blocks in a different style for
content downloaded from a URL

- Report some errors when unable to fetch content from a URL.

- Fixed a few small bugs along the way.
@geeknoid geeknoid merged commit 2258d0b into istio:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants