Update upgrade steps for Istio 1.3 #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
googlebot
added
the
cla: yes
geeknoid
reviewed
Sep 3, 2019
| @@ -58,14 +49,14 @@ This is suitable for cases where `kubectl apply` was used to deploy Istio CNI. | |||
| $ NAMESPACE=$(kubectl get pods -l k8s-app=istio-cni-node --all-namespaces --output='jsonpath={.items[0].metadata.namespace}') | |||
| {{< /text >}} | |||
|
|
|||
| 1. If `istio-cni` is currently installed in a namespace other than `kube-system` | |||
| 2. If `istio-cni` is currently installed in a namespace other than `kube-system` | |||
There was a problem hiding this comment.
Please leave numbered lists with 1. The right numbers will be inserted automatically when the page is generated.
| @@ -4,6 +4,9 @@ version: "1.3" | |||
| # The full Istio version identifier the docs describe | |||
| full_version: "1.3.0" | |||
|
|
|||
| # The previous Istio version identifier the docs describe, used for upgrade documentation | |||
| previous_version: "1.2" | |||
There was a problem hiding this comment.
In order to reference this symbol from markdown files, you need to add a shortcode definition in layouts/shortcodes.
There was a problem hiding this comment.
You should also update the release instructions in README.md to indicate this field needs to be updated when creating a new release.
geeknoid
approved these changes
Sep 3, 2019
|
/retest |
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4889
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure