Skip to content

Commit

Permalink
Fix missing separators in CRD files (#14844)
Browse files Browse the repository at this point in the history
Some of the workflows people use include `cat` of the CRD files.
While this is not recommended by the devs (instead we should be
recommending kubectl apply -f install/kubernetes/helm/istio-init/files/)
these two CRDs are improperly formatted which could lead to field
failure when operators use workflows not defined in the documentaiton.

Unfortunately our documentation also recommends this workflow here:
https://istio.io/docs/setup/kubernetes/install/multicluster/gateways/

which needs to be addressed separately.
  • Loading branch information
sdake authored and istio-testing committed Jun 15, 2019
1 parent 36779e1 commit 27a62f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,4 @@ spec:
shortNames:
- cert
- certs
---
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,4 @@ spec:
kind: Challenge
plural: challenges
scope: Namespaced
---

0 comments on commit 27a62f6

Please sign in to comment.