Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need tests/maintainer for TPROXY #17199

Closed
howardjohn opened this issue Sep 19, 2019 · 3 comments
Closed

Need tests/maintainer for TPROXY #17199

howardjohn opened this issue Sep 19, 2019 · 3 comments
Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.

Comments

@howardjohn
Copy link
Member

Currently we have a proxytproxy image that we ship. It has been broken many times, failed to get security patches, etc, because we have no maintainer for it.

We either need to have someone dedicate some time to maintaining this, including adding tests, or remove the feature as we cannot adequately support it right now.

@rlenglet
Copy link
Contributor

rlenglet commented Oct 4, 2019

The proxy_debug image is not tested either. Both need tests.

@howardjohn
Copy link
Member Author

We have removed proxy_debug.

I plan to remove TPROXY in 1.5 unless someone can take ownership here

howardjohn added a commit to howardjohn/istio that referenced this issue Dec 18, 2019
This was added without testing, documentation, or ownership, and as such doesn't
meet the requirements to be included in the project. We had an issue
requesting maintainers for months, and no one was interested. If anyone
does want to have this file, they should do the above. Until then, we
should not ship untested images to customers.

See istio#17199
istio-testing pushed a commit that referenced this issue Jan 29, 2020
This was added without testing, documentation, or ownership, and as such doesn't
meet the requirements to be included in the project. We had an issue
requesting maintainers for months, and no one was interested. If anyone
does want to have this file, they should do the above. Until then, we
should not ship untested images to customers.

See #17199
@rlenglet rlenglet removed their assignment Mar 30, 2020
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2019-11-24. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.
Projects
None yet
Development

No branches or pull requests

3 participants