Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The destination service label for tcp connection opened/closed metrics are inconsistent #17234

Closed
nrjpoddar opened this issue Sep 19, 2019 · 0 comments · Fixed by #17235
Closed

The destination service label for tcp connection opened/closed metrics are inconsistent #17234

nrjpoddar opened this issue Sep 19, 2019 · 0 comments · Fixed by #17235
Assignees
@nrjpoddar

Comments

@nrjpoddar
Copy link
Member

Bug description
Metrics istio_tcp_connections_closed_total and istio_tcp_connections_opened_total have destination_service label set to the destination.service.name attribute where as this label should be set to the destination.service.host as is done for all other metrics.

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Expected behavior
destination_service label is set to the destination.service.host attribute

Steps to reproduce the bug
Install Istio and run TCP traffic through the merge, query istio_tcp_connections_closed_total and istio_tcp_connections_opened_total metric.

Version (include the output of istioctl version --remote and kubectl version)
1.3, 1.2, 1.1
@nrjpoddar nrjpoddar self-assigned this Sep 19, 2019
nrjpoddar pushed a commit to nrjpoddar/istio that referenced this issue Sep 19, 2019
Set destination_service to destination.service.host
59b981b 
Fixes: istio#17234
@nrjpoddar nrjpoddar mentioned this issue Sep 19, 2019
Merged
istio-testing pushed a commit that referenced this issue Sep 20, 2019
@istio-testing
Set destination_service to destination.service.host (#17235)
4f429d1 
Fixes: #17234
istio-testing pushed a commit to istio-testing/istio that referenced this issue Sep 20, 2019
@istio-testing
Set destination_service to destination.service.host
f0c258e 
Fixes: istio#17234
istio-testing pushed a commit to istio-testing/istio that referenced this issue Sep 20, 2019
@istio-testing
Set destination_service to destination.service.host
a74706d 
Fixes: istio#17234
istio-testing added a commit that referenced this issue Sep 20, 2019
@istio-testing
Set destination_service to destination.service.host (#17268)
463083b 
Fixes: #17234
fpesce pushed a commit that referenced this issue Oct 16, 2019
@istio-testing
Set destination_service to destination.service.host (#17269)
f19f038 
Fixes: #17234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrjpoddar nrjpoddar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set destination_service to destination.service.host nrjpoddar/istio
1 participant
@nrjpoddar