Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] Set destination_service to destination.service.host #17268

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #17235

@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 20, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2019
@rlenglet
Copy link
Contributor

@bianpengyuan please consider adding an item into the 1.3.1 release note draft.

@rlenglet rlenglet added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Sep 20, 2019
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@rlenglet
Copy link
Contributor

/test racetest

1 similar comment
@rlenglet
Copy link
Contributor

/test racetest

@istio-testing istio-testing merged commit 463083b into istio:release-1.3 Sep 20, 2019
@istio-testing istio-testing deleted the cherry-pick-17235-to-release-1.3 branch September 20, 2019 17:37
@nrjpoddar
Copy link
Member

Thanks @bianpengyuan for updating the release notes for 1.3.1. Cheers!

Where is the WIP doc for 1.2.x release notes?

@bianpengyuan
Copy link
Contributor

@nrjpoddar I think there is no wip release doc for 1.2.x and @fpesce generates the release note at release time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants