Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated comment with proxiesQueueTime? #39147

Closed
j2gg0s opened this issue May 26, 2022 · 0 comments · Fixed by #40641
Closed

Outdated comment with proxiesQueueTime? #39147

j2gg0s opened this issue May 26, 2022 · 0 comments · Fixed by #40641
Labels
kind/docs

Comments

@j2gg0s
Copy link
Contributor

j2gg0s commented May 26, 2022 •
edited by istio-policy-bot
Loading

Bug Description

https://github.com/istio/istio/blob/master/pilot/pkg/xds/monitoring.go#L140

	// only supported dimension is millis, unfortunately. default to unitdimensionless.
	proxiesQueueTime = monitoring.NewDistribution(
		"pilot_proxy_queue_time",
		"Time in seconds, a proxy is in the push queue before being dequeued.",
		[]float64{.1, .5, 1, 3, 5, 10, 20, 30},
	)

Comment is outdated and confused?

Version

branch master

Additional Information

No response
howardjohn added a commit that referenced this issue Aug 24, 2022
@howardjohn
Fix stale comments
2918e6e 
Fixes #39147
@howardjohn howardjohn mentioned this issue Aug 24, 2022
Merged
istio-testing pushed a commit that referenced this issue Aug 24, 2022
@howardjohn
Fix stale comments (#40641)
2ec0662 
Fixes #39147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stale comments istio/istio
2 participants
@j2gg0s @istio-policy-bot