Add lifecycle + terminationgracepriod to GW Chart

[iainbowman]

Please provide a description of this PR:

The intention of this PR is to provide support for lifecycle (preStop hooks) and terminationGracePeriodSeconds to the Gateway deployment Helm chart.

[istio-policy-bot]

😊 Welcome @iainbowman! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[istio-testing]

Hi @iainbowman. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zirain]

see #38912 (comment)

[iainbowman]

Thanks, I wasn't aware of #38912 (comment) and I understand your position on not adding lots of new fields. Would love to give this a try but unfortunately as we are using ArgoCD to deploy and it currently does not support helm post-render this solution will not work for my use case.

[howardjohn]

Seems it could be done via https://argo-cd.readthedocs.io/en/stable/user-guide/kustomize/#kustomizing-helm-charts

[iainbowman]

Seems it could be done via https://argo-cd.readthedocs.io/en/stable/user-guide/kustomize/#kustomizing-helm-charts

Thanks I'll look into this 👍

[istio-policy-bot]

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-08-15. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.