Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document how to run the linters on only on one's changes (vs all files) #430

Closed
ldemailly opened this issue Jun 23, 2017 · 1 comment · Fixed by #442
Closed

document how to run the linters on only on one's changes (vs all files) #430

ldemailly opened this issue Jun 23, 2017 · 1 comment · Fixed by #442
Assignees
@ldemailly

Comments

@ldemailly
Copy link
Contributor

I tried bin/linters.sh -c master and some variants but haven't been able to get it to run only on local changes or the changes in a pr branch
@ldemailly ldemailly self-assigned this Jun 23, 2017
@ldemailly ldemailly changed the title document how to run the linters only on one's changes document how to run the linters on only on one's changes (vs all files) Jun 23, 2017
@ldemailly
Copy link
Contributor Author

One can set LAST_GOOD_GITSHA to whichever one wants as the diff point, for instance:

LAST_GOOD_GITSHA=HEAD bin/linters.sh

takes 10s (still seems pretty slow to check 1 file) instead of 30s to check local changes

ldemailly added a commit that referenced this issue Jul 1, 2017
@ldemailly
document how to run linters on only local changes
214ffdf 
fixes #430
@ldemailly ldemailly mentioned this issue Jul 1, 2017
Merged
ldemailly added a commit that referenced this issue Jul 2, 2017
@ldemailly
document how to run linters on only local changes (#442)
dc4f347 
fixes #430
rshriram pushed a commit that referenced this issue Oct 30, 2017
@ldemailly
document how to run linters on only local changes (#442)
b26bf27 
fixes #430

Former-commit-id: dc4f347
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@kyessenov
Stop using runtime image (#430)
55afa0b
mandarjog pushed a commit that referenced this issue Nov 2, 2017
@ldemailly
document how to run linters on only local changes (#442)
0b2f664 
fixes #430

Former-commit-id: dc4f347
guptasu added a commit to guptasu/istio that referenced this issue Jun 11, 2018
@guptasu
Add an optional option for template_name (istio#430)
7e10af2 
* Add an optional option for template_name
kyessenov pushed a commit to kyessenov/istio that referenced this issue Aug 13, 2018
@istio-merge-robot
Update_Dependencies (istio#430)
386b5ae 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn added a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@howardjohn @istio-testing
Use dev build instead of daily builds (istio#430)
05bff00 
Daily builds are no longer published

Also we don't have gencheck on this repo so some random changes are
included that are generated.
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@ostromart @istio-testing
Update README (istio#430)
f857f93 
* Update README

* Updates

* Comments

* Remove local build instructions

* Add instructions for local running

* Remove redundant readme
libesz pushed a commit to libesz/istio that referenced this issue Nov 11, 2021
@maistra-bot
Merge pull request istio#430 from shamsher31/istio-198
fa00254 
MAISTRA-2613 Update to latest Istio 1.9.8
antonioberben pushed a commit to antonioberben/istio that referenced this issue Jan 29, 2024
@batazor
Merge pull request istio#430 from elastisys/serviceExtraLable-for-jae…
4699285 
…ger-operator-service

[jaeger-operator] Adding serviceExtraLable for service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldemailly ldemailly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document how to run linters on only local changes istio/istio
1 participant
@ldemailly