Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore 1.27 IpAddress API #43952

Closed
howardjohn opened this issue Mar 15, 2023 · 7 comments
Closed

Explore 1.27 IpAddress API #43952

howardjohn opened this issue Mar 15, 2023 · 7 comments
Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@howardjohn
Copy link
Member

There is now an IPAddress API in k8s. We should explore how or if we should use this in Istio.

One possible idea is persisting the auto-allocated service entry IP addresses.

This is still alpha so we can't depend on it for a while, but worth exploring

cc @ramaraochavali @costinm @hzxuzhonghu @keithmattix

@keithmattix
Copy link
Contributor

keithmattix commented Mar 15, 2023

Linking the referenced KEP: kubernetes/enhancements#1880

@hzxuzhonghu
Copy link
Member

Great if can be used in istio, currently based on hash can have conflict

@hzxuzhonghu
Copy link
Member

learned about that, it is to create a IPAddress object for each IP it allocated. It do not expose a way for other controller to require an IP. I am not sure should we create do IP allocating like like it using IPAddress. If so it looks like no diff for us to create a svc placeholder for SE directly.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 14, 2023
@hanxiaop
Copy link
Member

not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 14, 2023
@howardjohn
Copy link
Member Author

One area it can be used is to do AutoAllocation for ServiceEntry. This basically allows k8s to allocate us an IP and we persist it into the cluster. Avoids ~all our issues with autoallocation I think

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Oct 5, 2023
@hzxuzhonghu
Copy link
Member

no stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Oct 7, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jan 5, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-10-07. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

5 participants