bin/runlinter.sh broken

[ldemailly]

used to work before #463

• bin/linter.sh -h yields bin/linters.sh: line 19: error_exit: command not found (all OSes)
• bin/linters.sh: line 62: declare: -A: invalid option when using -s HEAD on mac
• it also doesn't seem to work even on linux / select touched files (see log below)
• it should get the go packages list from bazel

Details : problem 2:

Running linters
All known packages are ./tests/e2e/... ./devel/githubContrib
Using HEAD to compare files to.
bin/linters.sh: line 62: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]

Mac/old bash only problem I guess

Details: Problem 3:

$ bin/linter.sh -s 3a429c7dae6fe1361fbfe525b4ba9eab311538ff
Running linters
All known packages are ./tests/e2e/... ./devel/githubContrib
Using 3a429c7dae6fe1361fbfe525b4ba9eab311538ff to compare files to.
Running linters on packages .
Done running linters
ldemailly@benchmark-1:~/go/src/istio.io/istio$ git diff 3a429c7dae6fe1361fbfe525b4ba9eab311538ff
diff --git a/devel/fortio/stats.go b/devel/fortio/stats.go
index 44f6e92..10a1139 100644
--- a/devel/fortio/stats.go
+++ b/devel/fortio/stats.go
@@ -292,7 +292,7 @@ func (h *Histogram) Log(msg string, percentile float64) {
        var b bytes.Buffer
        w := bufio.NewWriter(&b)
        h.Print(w, msg, percentile)
-       w.Flush() // nolint: gas,errcheck
+       w.Flush()
        log.Print(string(b.Bytes()))
 }
 

[sebastienvas]

devel/fortio is not declared as a package.

…

On Jul 16, 2017 2:23 AM, "Laurent Demailly" ***@***.***> wrote: used to work before #463 <#463> - bin/linter.sh -h yields bin/linters.sh: line 19: error_exit: command not found (all OSes) - bin/linters.sh: line 62: declare: -A: invalid option when using -s HEAD on mac - it also doesn't seem to work even on linux / select touched files (see log below) Details : problem 2: Running linters All known packages are ./tests/e2e/... ./devel/githubContrib Using HEAD to compare files to. bin/linters.sh: line 62: declare: -A: invalid option declare: usage: declare [-afFirtx] [-p] [name[=value] ...] Mac/old bash only problem I guess Details: Problem 3: $ bin/linter.sh -s 3a429c7 Running linters All known packages are ./tests/e2e/... ./devel/githubContrib Using 3a429c7 to compare files to. Running linters on packages . Done running linters ***@***.***:~/go/src/istio.io/istio$ git diff 3a429c7 diff --git a/devel/fortio/stats.go b/devel/fortio/stats.go index 44f6e92..10a1139 100644 --- a/devel/fortio/stats.go +++ b/devel/fortio/stats.go @@ -292,7 +292,7 @@ func (h *Histogram) Log(msg string, percentile float64) { var b bytes.Buffer w := bufio.NewWriter(&b) h.Print(w, msg, percentile) - w.Flush() // nolint: gas,errcheck + w.Flush() log.Print(string(b.Bytes())) } — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#471>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ80Z-omUy815GIBVCJwX73EOiDLKqW-ks5sOdasgaJpZM4OZPuo> .

[ldemailly]

that explains one problem but where is that done ? why a bazel build not enough?

[ldemailly]

oh I read the script, there are 2 packages there - I thought there was some explicit list somewhere and it was printing a summary

any way to get the actual package list from bazel instead of doing /... which is very coarse?

[ldemailly]

ping...

[sebastienvas]

Feel free to give it a go. This is is definitely not on priority list.

[linsun]

not a stop ship for v0.2

[ldemailly]

it works now