Workload on demand XDS test gap

[howardjohn]

istio/pilot/pkg/xds/workload_test.go

Line 175 in 0727ad5

createService(s, "svc1", "default", map[string]string{"app": "not-sa"})

Here if a full push happens, we would get removals for 127.0.0.1 and 127.0.0.2 unexpectedly. However, the test misses this because there happens to not be any full push during this time

[hzxuzhonghu]

Yesterday, i was investigating delta wds, and even cannot find a ut.

[howardjohn]

there is tests in workload_test.go. But it doesn't cover this case

…

On Mon, Jan 22, 2024, 11:10 PM Zhonghu Xu ***@***.***> wrote: Yesterday, i was investigating delta wds, and even cannot find a ut. — Reply to this email directly, view it on GitHub <#48915 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXKEPQC3YQD6WMNQMSDYP5O7TAVCNFSM6AAAAABCGCMHSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQZDIMZYG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jessicegao]

@howardjohn is this friendly to first time contributor

[howardjohn]

@jessicegao I would hold on this one for now; I found this during a major refactoring of this system so it may be wasted effort if it is refactored away anyways. I will let you know if that changes

[istio-policy-bot]

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2024-01-24. It will be closed on 2024-05-08 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.