ztunnel-config might not be printing out ztunnel data correctly

[MorrisLaw]

Is this the right place to submit this?

• This is not a security vulnerability or a crashing bug
• This is not a question about how to use Istio

Bug Description

draft PR #50806 describes this in detail with examples.

The ztunnel config dump writer does not appear to be getting the ztunnel config dump and unmarshalling that into the ztunnelDump struct correctly within the istioctl code. I think it's causing issues with how this data gets printed for commands like istioctl x ztunnel-config workload

Version

$ istioctl version
client version: 1.23-dev                                                                                                                                                               control plane version: 1.21.1                                                                                                                                                          data plane version: 1.21.1 (3 proxies)

Additional Information

#50806

[MorrisLaw]

The unit test shows the logic is fine assuming that the bytes to be unmarshalled contain the right fields. It seems my local environment does not produce the right data (confirmed by curling localhost:15000/config_dump and also by printing it out as shown in the draft PR linked above). Does not match the example of expected data structure in testdata/dump.json.

[MorrisLaw]

Link to output I'm seeing for my cluster: https://docs.google.com/document/d/1uwN0EWQNu7-T5POPodRW4Bnio86ZLZBW1LjnVBILuqo/edit?usp=sharing

Created my cluster following these steps: https://istio.io/latest/docs/ops/ambient/getting-started/

Istioctl generated from latest Istio branch. Ran make istioctl from istio root then called ./out/linux_amd64/istioctl x zc w. Similar steps described in draft PR.

[bleggett]

Does not match the example of expected data structure in testdata/dump.json.

We should probably have a schema or proto in both spots for this, or at least an istio-side integ test.

[howardjohn]

are you on latest version of both? it works for me. We changed the keys a while back

[MorrisLaw]

are you on latest version of both? it works for me. We changed the keys a while back

Ok, good! Wdym, when you say latest version of both @howardjohn ? The istio repo and ztunnel repo I have locally is as up to date as today, but maybe you're referring to something else?

[MorrisLaw]

I think my ztunnel binary was out of date, this is a non-issue