Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates of egress-auth and ingress-auth are out-of-date #531

Closed
yutongz opened this issue Aug 2, 2017 · 3 comments
Closed

Templates of egress-auth and ingress-auth are out-of-date #531

yutongz opened this issue Aug 2, 2017 · 3 comments

Comments

@yutongz
Copy link
Contributor

yutongz commented Aug 2, 2017

It seems not right that egress-auth.yaml and ingress-auth were updated 2 months ago while egress.yaml was updated 9 days ago. Since we changed the way feeding config, egress-auth doesn't work right now.
@yutongz
Copy link
Contributor Author

yutongz commented Aug 2, 2017

@lookuptable @andraxylia

@yutongz
Copy link
Contributor Author

yutongz commented Aug 2, 2017 •
edited
Loading

Here is a pr trying to fix this #504, but sure if there is any other issues on the old egress-auth and ingress-auth

@yutongz yutongz closed this as completed Aug 4, 2017
@yutongz
Copy link
Contributor Author

yutongz commented Aug 4, 2017

The templates are working right now. But we may still need to keep an eye on it when we change template. Lucky we will have e2e tests covering this issue really soon.

mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
@sebastienvas
Update jenkins pipeline version for codecov (istio#531)
e722a3c 
Former-commit-id: 0ca017c2c87797fcceae50adecf638b8e889174c
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@sebastienvas
Update jenkins pipeline version for codecov (#531)
098a3b2 
Former-commit-id: a0366a3723d05b22db0b731a07b757303b01064a
rshriram pushed a commit to rshriram/istio that referenced this issue Jul 31, 2018
@ozevren @istio-testing
Add core MCP protocol protos. (istio#531)
add0cbc 
* Add core MCP protocol protos.

* Accommodate CR feedback.

* Accommodate CR feedback.

* Accommodate CR feedback.

* Accommodate CR feedback.
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@ostromart @istio-testing
Modify prom operator root path (istio#531)
fa5f1c2 
* Modify prom operator root path

* Make gen
luksa pushed a commit to luksa/istio that referenced this issue Sep 20, 2022
@maistra-bot
Automator: Update proxy (istio#531)
c9ee7e8 
Co-authored-by: maistra-bot <null>
antonioberben pushed a commit to antonioberben/istio that referenced this issue Jan 29, 2024
@ML-std @pavelnikolov
[jaeger] Update Jaeger version (istio#531)
94950b7 
* Update Jaeger version

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>

* update appVersion to 1.53.0

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>

---------

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Co-authored-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yutongz