Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize mixer and proxy protobuf definitions in istio/api #557

Closed
vadimeisenbergibm opened this issue Aug 14, 2017 · 6 comments
Closed

Standardize mixer and proxy protobuf definitions in istio/api #557

vadimeisenbergibm opened this issue Aug 14, 2017 · 6 comments
Assignees
@kyessenov
Milestone
0.2

Comments

@vadimeisenbergibm
Copy link
Contributor

Currently, mixer uses "Required", while proxy used "REQUIRED". Should be "Required" in both.
@vadimeisenbergibm
Copy link
Contributor Author

Following @ZackButcher's proposal.

@vadimeisenbergibm vadimeisenbergibm mentioned this issue Aug 14, 2017
Merged
@ldemailly ldemailly added this to the Istio 0.2 milestone Aug 17, 2017
@ldemailly
Copy link
Contributor

similar to target/destination issue? we should get all the renames in before 0.2 ?

@rshriram
Copy link
Member

please move to istio/api

@sakshigoel12
Copy link
Contributor

rshriram@ - if you are using zenhub there is an option to move issues between repos on the right pane (last option). It would be easier to not close and reopen issues.

@sakshigoel12 sakshigoel12 mentioned this issue Aug 17, 2017
Closed
@rshriram
Copy link
Member

I was actually looking for such a feature! will look out for that next time. Thanks

@geeknoid geeknoid removed their assignment Aug 17, 2017
@ldemailly
Copy link
Contributor

screen shot 2017-08-17 at 1 39 54 pm

mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
@geeknoid
Sanitize error messages (istio#557)
cacd24f 
- Remove redundant use of "with err" in many error messages. These
were leading to generally confusing output.

- Try to use %v to format errors instead of %s.

Former-commit-id: ebc054a82b6c924d78aed8b3c109b5c4eb5a874a
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@geeknoid
Sanitize error messages (#557)
0c3b887 
- Remove redundant use of "with err" in many error messages. These
were leading to generally confusing output.

- Try to use %v to format errors instead of %s.

Former-commit-id: 53e24717272cb8f3b91d460f4414293fad43f767
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@lookuptable @kyessenov
Limit Istio CA to issue certs in its own namespace in integration test (
2b6a515 
#557)

* Limit Istio CA to issue certs in its own namespace in integration test

* fix bad tabs
rshriram pushed a commit to rshriram/istio that referenced this issue Jul 31, 2018
@geeknoid
We don't publish API proto docs to istio.io (istio#557)
e1274f2
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@richardwxn @istio-testing
remove egress sds (istio#557)
f9a10be 
* remove egress sds

* Remove extra role and rolebinding
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@ostromart @istio-testing
Sync to installer (istio#557)
3d2a23b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyessenov kyessenov

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
6 participants
@ldemailly @rshriram @kyessenov @sakshigoel12 @vadimeisenbergibm @geeknoid