Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for all the tasks #580

Closed
ldemailly opened this issue Aug 18, 2017 · 3 comments
Closed

e2e test for all the tasks #580

ldemailly opened this issue Aug 18, 2017 · 3 comments
Assignees
Milestone

Comments

@ldemailly
Copy link
Contributor

During the 0.1 launch we decided we should at least have automated coverage for every task we describe on the website https://istio.io/docs/tasks/ so those stay working at all times

https://github.com/istio/istio/issues?utf8=%E2%9C%93&q=is%3Aissue%20%22create%20e2e%20for%20Task%22%20is%3Aclosed%20

was the individual list. Some tests have been added since but it's unclear they all are

We should keep the tasks open until verified rather than mass close and hope it's ok

cc @sakshigoel12

@ldemailly ldemailly added this to the Istio 0.2 milestone Aug 18, 2017
@ldemailly ldemailly changed the title confirm we have e2e coverage for all the tasks mentioned in the docs confirm we have e2e test coverage for all the tasks mentioned in the docs Aug 18, 2017
@sakshigoel12
Copy link
Contributor

Added all the Tasks currently on website. We should evaluate if there are new tasks for 0.2

@sakshigoel12 sakshigoel12 changed the title confirm we have e2e test coverage for all the tasks mentioned in the docs e2e test coverage for all the tasks mentioned in the docs Aug 29, 2017
@sakshigoel12 sakshigoel12 changed the title e2e test coverage for all the tasks mentioned in the docs e2e test for all the tasks Aug 29, 2017
@sakshigoel12 sakshigoel12 modified the milestones: Istio 0.2, Istio 0.3 Sep 27, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
* Add canonicalization of service names to k8s adapter

* Address PR comments


Former-commit-id: 4906c6020583af25a75077bf8b944d586affdddb
mandarjog pushed a commit that referenced this issue Oct 31, 2017
* Add canonicalization of service names to k8s adapter

* Address PR comments


Former-commit-id: 246ad16c8df212f05f1448163766188d8a178021
mandarjog pushed a commit that referenced this issue Oct 31, 2017
* istioctl: improve error message when istio ConfigMap isn't found

* update message

* reword error message again
@rshriram rshriram removed their assignment Feb 8, 2018
@sakshigoel12
Copy link
Contributor

reopen if there are missing tests

@ldemailly
Copy link
Contributor Author

is there a tracking or replacement issue that will ensure those exist for/before 1.0 ?

rshriram pushed a commit to rshriram/istio that referenced this issue Jul 31, 2018
howardjohn added a commit to howardjohn/istio that referenced this issue Jan 12, 2020
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants